Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #639 #640

Closed
wants to merge 2 commits into from
Closed

Fix #639 #640

wants to merge 2 commits into from

Conversation

chainsawriot
Copy link

Description

Correct the partial matching of argument

Proposed Changes

See #639

@mattansb
Copy link
Member

The effect = argument actually shouldn't be partially matched, it is referring to cases where there are multiple effect types, but we only want the fixed effects (not relevant for aov or aovList models, where I thought it was just "absorbed" into ...).
So although your PR fixes this issue, it causes another issue.

I will try to think of a solution.

Originally posted by @mattansb in #639 (comment)

@mattansb mattansb closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants